Repository navigation
spec(FIX-2411): live session list with per-row status, model and recency - #4728
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiFQ8qXgjG9CR9fxF2b
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Second look + architecture pass (FIX-2411 spec)Checked the spec against 1. D1's cost can be cut now, at the publisher, instead of waiting for its flip (direction)D1 publishes
D1's flip is "tens of sessions running turns at once". Gating the user-topic notice on status-changing request writes + session create/delete/title/state writes is a small predicate in the one publisher. It makes the accepted price smaller up front and doesn't add a kind or a topic. Suggest D1 lock in the narrower rule, or state why the wide one is needed. 2. The publisher doesn't have the owner today (direction, small)
3. One home for "needs you" (architecture, for D2)D2 accepts two drawings of one row. The part that should not be drawn twice is the rule: 4. Don't copy the status rule (for the implementer)"Builds on Not raisedThe visibility-read workaround for Generated by Claude Code |
There was a problem hiding this comment.
Simplify review (FIX-2411 spec)
Direction looks right: reuse change-bus parent propagation, batched include: "status" on the listing, and useSubscription coalescing is a cleaner net than today's harness reads counter, Flow State hand leaf.refresh() calls, and the claude-code-style lab's per-row subscription pump. Deferring D3 and FIX-2552 is appropriate scope control.
I do not think the spec over-built relative to the goal. The main complexity is inherent (hear unlisted sessions and row status without N+1 or per-item reads). The rejected alternatives in DECISIONS match what the codebase already does (watchSessions, FIX-2466 reload-only, focus-only refresh).
Where the approach is as simple as it gets
- D1 (user-topic
run) vs per-row topics + create-only notices: the parent-chain extension is the smallest bus change that satisfies leg (a) and (b) with one subscription. FIX-2466's flip is acknowledged with a concrete escape hatch. include: "status"on the listing vs browser-side request reads: aligns with ER-5 and existingresolveDispatchRunStatuswork.- Two PRs (packages, then Kitchen Sink): keeps review and rollback sane.
Simpler shapes worth considering (non-blocking)
-
Public hook vs component —
packages/react/.../reads.tsdeliberately keeps leaf reads internal to avoid a third public list entry point that could multiply flow-list reads. This spec adds a second public list API besideuseFlow. That trade is documented, but at implementation time I'd keepuseSessionListas thin as possible (literallyuseFencedRead+useSubscriptionontopic.user(), shared withuseLeafSessionsvia one internal helper). If the only out-of-navigator consumer for a while is Kitchen Sink, an exportedsessionLabelhelper + documented hook pattern might have been enough for v1 — I'm not sure the public hook is premature; D2's builds-an-app row argues for export. Flagging for the gate, not requesting a spec rewrite. -
D2 row duplication — Two flat row renderers (navigator vs
HarnessSessionList) over one read is honest debt. To reduce drift without merging rails: exportsessionLabel(and maybe a tinySessionStatusMarkpresentational component) from@flow-state-dev/reactwhen dedupingENGINE_ID, instead of only deduping the regex in one package file. -
Coordinator /
railSessionspath (DECISIONS decided, not asked) — Flow State keeps a second, narrowed listing shape for coordinator rows. That's real app complexity. Worth a one-line implementer note so the page doesn't grow a third read pattern. -
useLeafSessionsopen-gate vs harness always-on — Spec should make explicit in the package PR thatuseSessionListis always enabled while mounted (harness rail), while the navigator continues to gate on leaf open via the existing hook internally. Otherwise implementers may accidentally reuse the closed-leafenabled: falsesemantics. -
Analysis — The embedded analysis is self-authored. Fine for draft; I'd still run the
analysisskill once before direction approval since D1 reverses FIX-2466 and adds a permanent second react list hook.
Performance (acceptable with eyes open)
- D1 means any turn on any of the user's sessions triggers a coalesced listing read for every open rail — correct for Kitchen Sink scale; the documented flip is the right pressure valve.
- Leg (b) anti-game should reuse the rule that
itemsdoes not publish on the user topic — worth an explicit implementer test.
Skipped (larger refactors)
- Flat single-flow
FlowNavigatormode (D2 rejected alternative): FIX-1494 long-term path. - Third-party library: no fit; framework owns bus + listing contracts.
Verdict: Approve the spec direction. Implementation should stay minimal — compose existing pieces, don't grow watchSessions-style pump state in react.
Sent by Cursor Automation: Review For Best Approach
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fcde389523
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The rows' request scopes differ, so the runs listing's batched read doesn't carry over; the listing reads at most two one-record reads per row on the server. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiFQ8qXgjG9CR9fxF2b
The user topic skips state field deltas, and a stop on other work is not waiting on you (requestWaitsForUser). Other review points recorded for the implementer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiFQ8qXgjG9CR9fxF2b
|
Review round 1 is folded in cc5885a.
Generated by Claude Code |
…ink bounded by its timer Kitchen Sink under Next serves no push socket, so its rail reads on the client's 3 s fallback timer. The one-second bound is proven where push is up; Kitchen Sink's browser test is bounded at 4 s. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiFQ8qXgjG9CR9fxF2b


Requested by Jake · project thread
fsdev runon the local SQLite storeuseSessionList. The rows are live and each has its state (D2)Goal: in each Kitchen Sink mode, the session rail shows a new session from anywhere on the server, and the latest turn state of each row, in less than 1 s, with no reload and no timer while push is up. A session from another process shows when the tab becomes visible again.
The check reads what the rail shows and counts listing reads. Check: a Kitchen Sink browser test (legs a, b) and a react test (leg c). Controls that must fail:
GOAL_CONTROL=no-user-notice(legs a, b),GOAL_CONTROL=no-show-read(leg c).The bus already tells when a session changes. This change adds the one topic that a list watches, the state that a row needs, and one hook that both rails use.
How: the bus also publishes
runon the user topic of the session owner. The listing returns the latest request status of each row when you ask for it. The navigator's leaf read becomes live and public.Sign off
The goal, at that size. If wrong: the rail shows new sessions but cannot show which run needs you.
The debt: net down. One read and its counter, two hand re-reads and a duplicate helper go. One hook comes in. If wrong: two list hooks in react drift apart.
Your user topic hears every change to your sessions · D1
It comes down to rows that are not listed yet: the topic of one session cannot tell about a different session. This is the one to weigh: it reverses FIX-2466 D1, by its own flip condition. If wrong: a user with many busy sessions makes each open rail read often.
One live read under both rails; the harness rail keeps its flat drawing · D2
It comes down to the navigator's shape: in a harness mode it adds a kind row to open first. If wrong: two drawings of one row drift apart.
The pull-request badge waits for a follow-up (FIX-2553) · D3
It comes down to reads: a badge costs one read per row. The state costs none past the listing. If wrong: you open a session to see its pull request.
Open: none. Reasons and what lost: DECISIONS.md.
Analysis: right approach, run by the author (no fresh sub-agent). DECISIONS.md → Analysis.
Reviewers · look here
fsdev runon SQLite, where the in-memory bus says that it crosses processes. Does this go against FIX-2369 D2?useSessionListis a second public list hook besideuseFlow. Is "extends useLeafSessions" correct?Not here: the claude-code-style lab's list (FIX-2552), the pull-request badge (FIX-2553), navigator leaf events (FIX-1494).
Spec · Decisions · Linear FIX-2411 · epic FIX-2369 · builds on FIX-2426, FIX-2428 · amends FIX-2426's publish table, supersedes part of FIX-2466 D1 · merges after human approval and required checks
How to review this — altitude, what's in scope, what's deliberately unsettled
This is a direction set, not an implementation and not a build plan. Reviewing it well means
answering one question: is this the right approach?
In scope to challenge:
SPEC.md— is the goal the real need at full size,for the people named, or a smaller goal that would let us call this done early? Would the
named check fail if the goal were not met?
docs/philosophy.md?DECISIONS.md— that's the sign-off surface.SPEC.md→ What's already here, and the debt — an existing primitive,method or prior design the change overlaps and doesn't name; something it adds that is debt
and isn't listed; a net verdict the tables don't support.
piece it considered, or that is a second mechanism for something we already have
(
orchestration.md).design.
Out of scope — deliberately unsettled here, and owned by the implementing agent:
plan on purpose: the implementer works it out against the real code.
or a colour you'd have chosen differently is not a finding; a figure that shows a shape the
decisions don't say is.
poc/are retained,not production code. Read them for directional evidence, not production completeness.
Their isolation from production/default discovery and absence of secrets or generated
dependencies are in scope; retention is not permission to weaken repository checks.
One request, if you are an automated reviewer: the two lists above are the whole difference
between a useful review of this document and a long one. Volume is not signal here — a single
finding above the line is worth more than twenty below it.
Feedback in the second list is welcome and gets recorded verbatim in
DECISIONS.md → Notes from reviewfor the implementer to weigh against real code. It will notbe argued with, and it will not be folded into the design prose. Please don't re-raise it: one
mention is enough.
The one exception is the POC. Line-level feedback on it is dropped, not recorded — there
is nothing for an implementer to weigh about code that isn't shipping. Feedback about its
direction is not line-level and is treated like any other above-the-bar finding.
Direction approval does not waive merge-time required checks, approvals or thread policy.
Optional comments do not require another design round merely to reach zero comments.
Generated by Claude Code